Commit Graph

103 Commits

Author SHA1 Message Date
Markus Lude
870e1f7eed fix WikiBugs/PwlistArray
reported and fix contributed by JuanmaMP
2017-10-29 17:31:53 +01:00
Markus Lude
d3b07e925d fix WikiBugs/UnusedVariableDeclaration
reported and fix contributed by JuanmaMP
2017-10-29 16:49:23 +01:00
Markus Lude
110664adb9 fix for taint mode:
wiki.pl: Insecure dependency in unlink while running with -T switch at /var/www/cgi-bin/wiki.pl line 4774.

taint error on page delete

in DoDeletePage():
use new variable $unsafe_id for tainted id
untaint id (page name)
2017-10-29 02:16:49 +02:00
Markus Lude
e80c4cd8d5 fix for taint mode:
wiki.pl: Insecure dependency in open while running with -T switch at /var/www/cgi-bin/wiki.pl line 2946.

taint error on page lock/unlock

in DoPageLock():
use new variable $unsafe_id for tainted id
untaint id (page name)
2017-10-29 02:09:48 +02:00
Markus Lude
f4822aa6e8 in DoLogin():
use new variable $unsafe_uid for tainted user id
untaint uid
2017-10-29 01:56:57 +02:00
Markus Lude
bf012db309 new function SanitizeUserID():
untaints parameter $unsafe_uid
returns uid or 111 in error case
(UserID 111 means invalid UserID)

in InitCookie():
use new variable $unsafe_uid for tainted user id
2017-10-29 01:55:47 +02:00
Markus Lude
a3f1349664 fix for taint mode:
wiki.pl: Insecure dependency in open while running with -T switch at /var/www/cgi-bin/wiki.pl line 2935.

taint error on Preferences page
2017-10-29 01:34:46 +02:00
Markus Lude
cca8fc0aa6 add CREDITS 2017-10-29 01:28:14 +02:00
Markus Lude
59aae67859 simplify SanitizePageName() 2017-10-29 01:23:14 +02:00
Markus Lude
18e2417539 new function SanitizePageName():
untaints parameter $unsafe_id
returns id or "" in error case

in DoPost():
use new variable $unsafe_id for tainted id
2017-10-29 01:21:02 +02:00
Markus Lude
d4ba6323a3 fix for taint mode:
wiki.pl: Insecure dependency in open while running with -T switch at /var/www/cgi-bin/wiki.pl line 2927.

taint error on save on page edit
2017-10-29 01:08:39 +02:00
Markus Lude
15412f6695 enable taint mode (perl -T) 2017-10-29 01:02:35 +02:00
Markus Lude
b175a5b4e5 fix warning:
wiki.pl: Use of uninitialized value $UseModWiki::ConfigError in string ne at /var/www/cgi-bin/wiki.pl line 1471.

warning if no config file present
2017-10-29 00:37:44 +02:00
Markus Lude
0cf89ae446 in WikiToHTML():
initialize global variable $TableOfContents if not initialized yet
2017-10-29 00:33:34 +02:00
Markus Lude
0568007328 in GetHistoryLine():
initialize variable $html
2017-10-29 00:31:14 +02:00
Markus Lude
d40a1b150f fix warnings:
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1392.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1116.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1116.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1123.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1123.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1116.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1116.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1116.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in string at ./wiki.pl line 1501.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1123.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1123.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1116.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1123.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1116.
wiki.pl: Use of uninitialized value $UseModWiki::ScriptName in concatenation (.) or string at ./wiki.pl line 1116.
2017-10-29 00:27:53 +02:00
Markus Lude
7f1c918633 fix warning:
wiki.pl: Use of uninitialized value $ENV{"SCRIPT_NAME"} in string at ./wiki.pl line 414.
2017-10-29 00:26:09 +02:00
Markus Lude
da5eaed40e fix warnings:
wiki.pl: Use of uninitialized value $description in concatenation (.) or string at /var/www/cgi-bin/wiki.pl line 967.
wiki.pl: Use of uninitialized value $authorLink in concatenation (.) or string at /var/www/cgi-bin/wiki.pl line 967.

warnings on RSS page
2017-10-29 00:14:22 +02:00
Markus Lude
5c48d9a789 fix warnings:
wiki.pl: Use of uninitialized value $UseModWiki::UserData{"password"} in join or string at /var/www/cgi-bin/wiki.pl line 3781.
wiki.pl: Use of uninitialized value $UseModWiki::UserData{"stylesheet"} in join or string at /var/www/cgi-bin/wiki.pl line 3781.
wiki.pl: Use of uninitialized value $UseModWiki::UserData{"adminpw"} in join or string at /var/www/cgi-bin/wiki.pl line 3781.
wiki.pl: Use of uninitialized value $UseModWiki::UserData{"username"} in join or string at /var/www/cgi-bin/wiki.pl line 3781.

warnings on Preferences page
2017-10-29 00:08:08 +02:00
Markus Lude
16660d99f9 fix warning:
wiki.pl: Use of uninitialized value $rhost in string eq at /var/www/cgi-bin/wiki.pl line 3120.

warning on page edit
2017-10-29 00:01:12 +02:00
Markus Lude
8d39add40a fix warning:
wiki.pl: Use of uninitialized value in string eq at /var/www/cgi-bin/wiki.pl line 3332.

warning on page edit
2017-10-28 23:59:21 +02:00
Markus Lude
31e4f86676 fix warning:
wiki.pl: Use of uninitialized value in string ne at /var/www/cgi-bin/wiki.pl line 2648.

warning on page history
2017-10-28 21:18:54 +02:00
Markus Lude
a0419ff448 fix warnings:
wiki.pl: Use of uninitialized value $c1 in concatenation (.) or string at /var/www/cgi-bin/wiki.pl line 1076.
wiki.pl: Use of uninitialized value $c2 in concatenation (.) or string at /var/www/cgi-bin/wiki.pl line 1078.

warnings on page history
2017-10-28 21:16:27 +02:00
Markus Lude
da6052adeb fix warning:
wiki.pl: Use of uninitialized value $UseModWiki::QuotedFullUrl in concatenation (.) or string at /var/www/cgi-bin/wiki.pl line 778.

warning on RecentChanges page
2017-10-28 21:13:20 +02:00
Markus Lude
cc41abd92c fix warning:
wiki.pl: Use of uninitialized value $text in concatenation (.) or string at /var/www/cgi-bin/wiki.pl line 1967.

warning on normal page view, page contains <toc>
2017-10-28 19:29:07 +02:00
Markus Lude
8f23adcc7a fix warning:
wiki.pl: Use of uninitialized value $extra in concatenation (.) or string at /var/www/cgi-bin/wiki.pl line 1977.

warning on normal page view, page contains URL
2017-10-28 19:26:13 +02:00
Markus Lude
aff1b8387d fix warning:
wiki.pl: Use of uninitialized value $UseModWiki::UserData{"tzoffset"} in numeric ne (!=) at /var/www/cgi-bin/wiki.pl line 463.

warning on normal page view
2017-10-28 19:09:18 +02:00
Markus Lude
6a64c22e12 fix warnings:
wiki.pl: Use of uninitialized value $UseModWiki::UserID in substitution (s///) at /var/www/cgi-bin/wiki.pl line 450.
wiki.pl: Use of uninitialized value $UseModWiki::UserID in numeric lt (<) at /var/www/cgi-bin/wiki.pl line 451.

warnings on normal page view
2017-10-28 19:06:16 +02:00
Markus Lude
19ad47ff11 fix warning:
wiki.pl: Use of uninitialized value $_ in string ne at /var/www/cgi-bin/wiki.pl line 5189.

warning on normal page view
2017-10-28 19:03:41 +02:00
Markus Lude
9f68448d5f fix warnings:
wiki.pl: length() used on @kplist (did you mean "scalar(@kplist)"?) at /var/www/cgi-bin/wiki.pl line 2571.
wiki.pl: length() used on @kplist (did you mean "scalar(@kplist)"?) at /var/www/cgi-bin/wiki.pl line 2573.
wiki.pl: length() used on @kplist (did you mean "scalar(@kplist)"?) at /var/www/cgi-bin/wiki.pl line 4813.
wiki.pl: length() used on @kplist (did you mean "scalar(@kplist)"?) at /var/www/cgi-bin/wiki.pl line 4815.

warnings on normal page view
2017-10-28 18:57:29 +02:00
Markus Lude
59fc58fbab enable warnings (perl -w) 2017-10-28 18:54:40 +02:00
Markus Lude
c6ee9ee1ac some preparations for 1.0.6: bump version v1.0.6 2016-11-05 16:43:26 +01:00
Markus Lude
479225d1d9 fixed WikiBugs/SkipMigratingParameterLock
based on fix by GyPark
2016-11-05 16:39:28 +01:00
Markus Lude
c4a95bf817 fixed WikiBugs/CGIStartformAndEndform 2016-11-05 16:17:51 +01:00
Markus Lude
eedbd60ba9 fixed WikiBugs/CookieIgnored 2016-10-26 15:51:22 +02:00
Markus Lude
31361f5c2d some preparations for 1.0.5: bump version v1.0.5 2016-10-25 20:16:59 +02:00
Markus Lude
d50a72c86d UriEscape(): more chars needed in whitelist, pointed out by JuanmaMP 2016-10-25 20:15:12 +02:00
Markus Lude
c0bb6e62c1 small fix, other problems with diff pages for example 2016-10-25 20:09:47 +02:00
Markus Lude
a5eb14d28e UriEscape(): better use white listing than black listing
mostly from GunnarH, mentioned on WikiBugs/NonEnglishRSS
2016-10-25 20:08:45 +02:00
Markus Lude
32a13c5e8b fixed WikiBugs/NonEnglishRSS
fixes contributed by GunnarH
2016-10-25 20:07:57 +02:00
Markus Lude
33bef450e8 GetHtmlHeader(): modified patch RssLinkInHeader:
link to RSS only on normal pages (no action stuff)
2016-10-25 20:06:23 +02:00
Markus Lude
39995d1c0c fixed WikiBugs/TTatDoEditBanned
fix contributed by JuanMtnezPineda
2016-10-25 20:04:07 +02:00
Markus Lude
d521f7011d DoLinks(): backout change from 8429294b5c,
keep extra lines
2016-10-25 20:02:48 +02:00
Markus Lude
c64c3ff54c removed unnecessary hr tag in DoLinks() 2016-10-25 20:01:34 +02:00
Markus Lude
8429294b5c added fix for WikiBugs/ExtraBRAtDoBackLinks
contributed by JuanMtnezPineda (JuanmaMP)
extended it for DoHistory(), DoUpdatePrefs(), DoIndex(), DoSearch(),
DoMaintain(), DoMaintainRc()
removed similar padding in DoLinks()
2016-10-25 20:00:46 +02:00
Markus Lude
21c98985bc fix example in config section, fix spacing 2016-10-25 19:59:22 +02:00
Markus Lude
8814048cfc fixed WikiBugs/NumericDatesNeedZeroPadding
fix contributed by GunnarH
2016-10-25 19:57:54 +02:00
Markus Lude
26037dd0dd Allow "0" as page name if FreeLinks are allowed 2016-10-25 19:56:04 +02:00
Markus Lude
49cec5752d refine last patch, use int flag instead of param value 2016-10-25 19:55:08 +02:00
Markus Lude
78a833233c added WikiPatches/DoPageLockMinorTweak
contributed by JuanMtnezPineda (JuanmaMP)
extended it for DoEditLock() too
2016-10-25 19:54:17 +02:00