141 Commits

Author SHA1 Message Date
Aki Goto
25aa740c2a fix for using with FastCGI servers 2022-09-22 11:14:33 +09:00
Markus Lude
14c06ba45d some preparations for 1.2.1: bump version v1.2.1 2017-12-01 08:25:46 +01:00
Markus Lude
f008b5c0fd cleanup generated HTML code on history page
in DoHistory():
remove unneccessary <tr>

in GetHistoryLine():
close <td>
2017-11-18 01:30:09 +01:00
Markus Lude
ba421c2d6a RSS: fall back to LogoUrl for RssLogoUrl 2017-11-18 00:42:01 +01:00
Markus Lude
291d474327 fix EditHash
in DoPost():
actually check the hash
2017-11-16 08:12:10 +01:00
Markus Lude
4a7553ced4 in GetFooterText():
dont call GetMinimumFooter(), no nested Footer functions
use end_html instead
2017-11-15 19:24:19 +01:00
Markus Lude
acf20ddadd * put <hr> class wikilinerc inside of div for class wikirc 2017-11-15 19:19:12 +01:00
Markus Lude
21ebc21f8e closing div for class wikibody was missing at some places
added </div>
2017-11-15 08:40:39 +01:00
Markus Lude
1d521cdc40 use GetIP() at all relevant places 2017-11-05 21:16:56 +01:00
Markus Lude
2ad2e04c33 some preparations for 1.2.0: bump version v1.2.0 2017-11-05 19:11:55 +01:00
Markus Lude
380be5160c in DoPost():
better use same constant here as in DoEditPrefs()
2017-11-05 18:20:38 +01:00
Markus Lude
ee1e6b9b65 use variable without "" 2017-11-05 16:40:46 +01:00
Markus Lude
b1a6c615cf in InitCookie():
use return value of LoadUserData()
2017-11-05 14:35:34 +01:00
Markus Lude
182fbdd079 in DoLogin():
use return value of LoadUserData()
2017-11-05 14:31:40 +01:00
Markus Lude
d00245b234 in LoadUserData():
add check if uid is too small
return 1 if loading was successful, 0 otherwize
2017-11-05 14:24:19 +01:00
Markus Lude
ba3686996f in InitCookie():
add parameter uid
use parameter uid for check and call of LoadUserData()
2017-11-05 12:39:23 +01:00
Markus Lude
eda0a5ee5a in LoadUserData():
add parameter uid
use parameter uid instead of global variable UserID
2017-11-05 12:29:13 +01:00
Markus Lude
026a769e0a in GetHtmlHeader():
replace "/" with ", " in keywords for subpages
2017-11-05 12:16:47 +01:00
Markus Lude
070ff2c704 use three-argument form of open 2017-11-02 23:56:08 +01:00
Markus Lude
8e3f7824eb no space between function name and left bracket 2017-11-02 23:51:13 +01:00
Markus Lude
d71a118d19 add EditHash 2017-11-02 23:46:12 +01:00
Markus Lude
f14d05103c in GetRemoteHost():
show IP address instead of faked DNS entry on RecentChanges

RecentChanges showed host names which dont make sense like localhost
or all IP addresses in a netblock resolve to the same host name.
The real IP address is lost then (apart from web server logs)

check if REMOTE_ADDR address resolves to a host name
resolve that host name to an IP address
if both ip addresses are the same, then host name is ok to use
2017-11-02 23:40:06 +01:00
Markus Lude
3aa96dd404 fix WikiBugs/CallingKeepFileName
reported by JuanmaMP
2017-11-02 23:36:57 +01:00
Markus Lude
44e500ae44 in KeepFileName():
add parameter name
use $name instead of $OpenPageName

add parameter (= $OpenPageName) to all calls of KeepFileName()
2017-11-02 23:33:34 +01:00
Markus Lude
70488b0c98 added CSS class wikibody to include all except wikiheader and wikifooter
suggested by UngarPeter on ProposalFor1.1
2017-11-02 23:30:33 +01:00
Markus Lude
2950d9a81c re-order entries
first action, then method
2017-11-02 23:24:49 +01:00
Markus Lude
de4e395c6c move favicon related markup 2017-11-02 23:20:14 +01:00
Markus Lude
2883da1bf9 fix markup: close <dd> tags 2017-11-02 23:18:59 +01:00
Markus Lude
c99cad8cc9 fix markup: close <dt> tags 2017-11-02 23:10:41 +01:00
Markus Lude
08687dd8d8 cleanup generated HTML code
use "" around class values
add value to noshade
2017-11-02 23:08:32 +01:00
Markus Lude
418b667f28 add \n after closing div tag 2017-11-02 22:29:25 +01:00
Markus Lude
f94bebe31e removed self closing from tag (<.../>), xml style but we use html 2017-11-02 22:26:16 +01:00
Markus Lude
3a46d68d6f combine splitted /pre tags 2017-11-02 22:23:01 +01:00
Markus Lude
f6c8f13015 use lowercase html tags and attributs 2017-11-02 22:22:23 +01:00
Markus Lude
2214a8175a switch DTD to HTML 4.0.1 Transitional 2017-11-02 22:00:16 +01:00
Markus Lude
b11337d2d6 some preparations for 1.1.0: bump version v1.1.0 2017-10-31 20:58:50 +01:00
Markus Lude
501a7e36f4 remove unused variables 2017-10-31 16:57:38 +01:00
Markus Lude
9474e6789a fix warning:
wiki.pl: Use of uninitialized value within %UseModWiki::SaveNumUrl in numeric gt (>) at /var/www/cgi-bin/wiki.pl line 1926.

warning on normal page view, page contains BracketUrl ([http://...])
2017-10-29 19:44:14 +01:00
Markus Lude
870e1f7eed fix WikiBugs/PwlistArray
reported and fix contributed by JuanmaMP
2017-10-29 17:31:53 +01:00
Markus Lude
d3b07e925d fix WikiBugs/UnusedVariableDeclaration
reported and fix contributed by JuanmaMP
2017-10-29 16:49:23 +01:00
Markus Lude
110664adb9 fix for taint mode:
wiki.pl: Insecure dependency in unlink while running with -T switch at /var/www/cgi-bin/wiki.pl line 4774.

taint error on page delete

in DoDeletePage():
use new variable $unsafe_id for tainted id
untaint id (page name)
2017-10-29 02:16:49 +02:00
Markus Lude
e80c4cd8d5 fix for taint mode:
wiki.pl: Insecure dependency in open while running with -T switch at /var/www/cgi-bin/wiki.pl line 2946.

taint error on page lock/unlock

in DoPageLock():
use new variable $unsafe_id for tainted id
untaint id (page name)
2017-10-29 02:09:48 +02:00
Markus Lude
f4822aa6e8 in DoLogin():
use new variable $unsafe_uid for tainted user id
untaint uid
2017-10-29 01:56:57 +02:00
Markus Lude
bf012db309 new function SanitizeUserID():
untaints parameter $unsafe_uid
returns uid or 111 in error case
(UserID 111 means invalid UserID)

in InitCookie():
use new variable $unsafe_uid for tainted user id
2017-10-29 01:55:47 +02:00
Markus Lude
a3f1349664 fix for taint mode:
wiki.pl: Insecure dependency in open while running with -T switch at /var/www/cgi-bin/wiki.pl line 2935.

taint error on Preferences page
2017-10-29 01:34:46 +02:00
Markus Lude
cca8fc0aa6 add CREDITS 2017-10-29 01:28:14 +02:00
Markus Lude
59aae67859 simplify SanitizePageName() 2017-10-29 01:23:14 +02:00
Markus Lude
18e2417539 new function SanitizePageName():
untaints parameter $unsafe_id
returns id or "" in error case

in DoPost():
use new variable $unsafe_id for tainted id
2017-10-29 01:21:02 +02:00
Markus Lude
d4ba6323a3 fix for taint mode:
wiki.pl: Insecure dependency in open while running with -T switch at /var/www/cgi-bin/wiki.pl line 2927.

taint error on save on page edit
2017-10-29 01:08:39 +02:00
Markus Lude
15412f6695 enable taint mode (perl -T) 2017-10-29 01:02:35 +02:00