archive/oddmuse
2
0
Fork 0
forked from github/kensanata.oddmuse
Code Pull Requests Activity

meta.t: remove -T from the syntax check

Browse Source 
When testing it on my system, perl -c claims ban-contributors.pl is
good and perl -cT claims ban-contributors.pl bad because it can no
longer find Net/Whois/Parser.pm in @INC even though it's right there
as /home/alex/perl5/lib/perl5/Net/Whois/Parser.pm -- apparently taint
checking changes @INC.
<http://perldoc.perl.org/perlsec.html#Taint-mode-and-%40INC>.
This commit is contained in:
Alex Schroeder
2016-07-27 14:01:51 +02:00
parent 5b0e4aea6b
commit ca259d46bd
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
t/meta.t
View File

@@ -111,10 +111,10 @@ unless (ok(@badModules == 0, 'AddModuleDescription is used in every module')) {
}
# we have to use shell to redirect the output :(
@badModules = grep { system("perl -cT \Q$_\E > /dev/null 2>&1") != 0 } @modules;
@badModules = grep { system("perl -c \Q$_\E > /dev/null 2>&1") != 0 } @modules;
unless (ok(@badModules == 0, 'modules are syntatically correct')) {
diag(qq{$_ has syntax errors}) for @badModules;
diag("▶▶▶ Use this command to see the problems: for f in @badModules; do perl -cT \$f; done");
diag("▶▶▶ Use this command to see the problems: for f in @badModules; do perl -c \$f; done");
}
my %changes = (