archive/oddmuse
2
0
Fork 0
forked from github/kensanata.oddmuse
Code Pull Requests Activity

simple-rules.pl uses strict

Browse Source 
Variables which are essentially global and which contain state are
localized before they are set. In order to localize them, they have to
be declared here using vars, first.
This commit is contained in:
Alex Schroeder
2015-03-29 23:31:13 +02:00
parent 2d2b55decf
commit 54f56dad9d
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/simple-rules.pl
View File

@@ -16,7 +16,7 @@
# 59 Temple Place, Suite 330
# Boston, MA 02111-1307 USA
#use strict; #TODO local variables? What?
use strict;
AddModuleDescription('simple-rules.pl', 'Simple Fast Alternate Text Formatting Rules');
use vars qw($q $OpenPageName $FS $UrlPattern $FreeLinkPattern);
@@ -26,6 +26,10 @@ use vars qw($q $OpenPageName $FS $UrlPattern $FreeLinkPattern);
my $PROT = "\x1c";
my $DIRT = "\x1d";
# Variables which are essentially global and which contain state are localized before they are set. In order to localize
# them, they have to be declared here, first.
use vars qw($counter %protected %dirty);
sub NewSimpleRulesApplyRules {
# locallinks: apply rules that create links depending on local config (incl. interlink!)
my ($text, $locallinks, $withanchors, $revision) = @_;
@@ -120,7 +124,7 @@ sub SimpleRulesMungeResult {
my @flags;
my $count = 0;
my $html;
foreach $item (split(/$DIRT([0-9]+)$DIRT/, $raw)) {
foreach my $item (split(/$DIRT([0-9]+)$DIRT/, $raw)) {
if ($count % 2) { # deal with reference
if ($dirty{$item}) { # dirty block
if ($html) {