From c791cef9c6ce1431cda60e43f14a06198db92dff Mon Sep 17 00:00:00 2001 From: Dmitry Maluka Date: Fri, 3 Nov 2023 00:51:30 +0100 Subject: [PATCH] Fix default setting for global & common options Apply the same fix as 4d13308 to all kinds of options, not just to plugin options. --- internal/config/settings.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/internal/config/settings.go b/internal/config/settings.go index 72e998f1..af472651 100644 --- a/internal/config/settings.go +++ b/internal/config/settings.go @@ -239,7 +239,7 @@ func RegisterGlobalOptionPlug(pl string, name string, defaultvalue interface{}) // RegisterCommonOption creates a new option func RegisterCommonOption(name string, defaultvalue interface{}) error { - if v, ok := GlobalSettings[name]; !ok { + if _, ok := GlobalSettings[name]; !ok { defaultCommonSettings[name] = defaultvalue GlobalSettings[name] = defaultvalue err := WriteSettings(filepath.Join(ConfigDir, "settings.json")) @@ -247,14 +247,14 @@ func RegisterCommonOption(name string, defaultvalue interface{}) error { return errors.New("Error writing settings.json file: " + err.Error()) } } else { - defaultCommonSettings[name] = v + defaultCommonSettings[name] = defaultvalue } return nil } // RegisterGlobalOption creates a new global-only option func RegisterGlobalOption(name string, defaultvalue interface{}) error { - if v, ok := GlobalSettings[name]; !ok { + if _, ok := GlobalSettings[name]; !ok { DefaultGlobalOnlySettings[name] = defaultvalue GlobalSettings[name] = defaultvalue err := WriteSettings(filepath.Join(ConfigDir, "settings.json")) @@ -262,7 +262,7 @@ func RegisterGlobalOption(name string, defaultvalue interface{}) error { return errors.New("Error writing settings.json file: " + err.Error()) } } else { - DefaultGlobalOnlySettings[name] = v + DefaultGlobalOnlySettings[name] = defaultvalue } return nil }