From 4d1330862414311359d18a24fc81ba161643f24c Mon Sep 17 00:00:00 2001 From: Zachary Yedidia Date: Sat, 20 Jun 2020 20:07:33 -0400 Subject: [PATCH] Persist plugin options correctly --- internal/config/settings.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/config/settings.go b/internal/config/settings.go index 55aed63e..7b45d12f 100644 --- a/internal/config/settings.go +++ b/internal/config/settings.go @@ -205,7 +205,7 @@ func OverwriteSettings(filename string) error { // RegisterCommonOptionPlug creates a new option (called pl.name). This is meant to be called by plugins to add options. func RegisterCommonOptionPlug(pl string, name string, defaultvalue interface{}) error { name = pl + "." + name - if v, ok := GlobalSettings[name]; !ok { + if _, ok := GlobalSettings[name]; !ok { defaultCommonSettings[name] = defaultvalue GlobalSettings[name] = defaultvalue err := WriteSettings(filepath.Join(ConfigDir, "settings.json")) @@ -213,7 +213,7 @@ func RegisterCommonOptionPlug(pl string, name string, defaultvalue interface{}) return errors.New("Error writing settings.json file: " + err.Error()) } } else { - defaultCommonSettings[name] = v + defaultCommonSettings[name] = defaultvalue } return nil }