Alex Schroeder
f98374df9b
PrintFooter relies on @MyFooters
...
We already called all the subs on @MyFooters and printed the result,
but this commit moves all the code from PrintFooters into subs and
puts those subs on @MyFooters. This allows us to write modules that
can better control where exactly their output should appear. In this
case the change was required in order to allow the Google +1 module to
coexist with code that maybe prints the comment form for all pages.
For example, knowing that the Google +1 sub is the first on one the
list because of unshift(@MyFooters, \&GooglePlusPrintFooter), we can
now write the following:
splice(@MyFooters, 1, 0, \&MyCommentsInTheFooter);
sub MyCommentsInTheFooter {
my ($id, $rev, $comment) = @_;
if (not $GooglePlusThisPagePrintedJournal
and (GetParam('action', 'browse') eq 'browse'
and $id and $CommentsPrefix
and $id ne $RCName
and $id !~ /^$CommentsPrefix(.*)/o)) {
my $target = $CommentsPrefix . $id;
my $page = '';
$page = PageHtml($target) if $IndexHash{$target};
return $q->div({-class=>'comment'},
$q->h2(T('Comments')),
$page)
. GetCommentForm("$CommentsPrefix$id", $rev, $comment);
}
}
The Google +1 extension was also fixed to not triger the EFF's Privacy
Badger. This is OK because we're using a two step button: The user
needs to click a button before we're loading the script from Google.
2015-08-17 13:39:34 +02:00
..
2015-04-06 20:57:35 +02:00
2015-07-08 15:06:21 +02:00
2015-07-28 10:55:13 +02:00
2015-04-11 23:41:33 +03:00
2015-04-27 17:41:59 +03:00
2015-07-31 09:35:51 +02:00
2015-04-12 22:50:50 +03:00
2015-04-27 17:41:59 +03:00
2015-04-11 23:41:33 +03:00
2015-07-03 14:26:59 +02:00
2015-07-28 21:59:47 +02:00
2015-04-11 23:41:33 +03:00
2015-07-28 22:44:53 +02:00
2015-04-10 13:31:28 +03:00
2015-04-11 23:41:33 +03:00
2015-07-03 13:01:32 +02:00
2015-07-03 13:01:32 +02:00
2015-04-27 17:41:59 +03:00
2015-04-28 00:03:11 +03:00
2015-04-11 23:41:33 +03:00
2015-04-11 23:41:33 +03:00
2015-08-15 10:32:11 +02:00
2015-07-28 23:02:23 +02:00
2015-04-10 13:31:28 +03:00
2015-04-27 17:41:59 +03:00
2015-04-10 13:31:28 +03:00
2015-04-17 01:39:47 +03:00
2015-04-11 23:41:33 +03:00
2015-08-07 02:43:46 +03:00
2015-04-10 13:31:28 +03:00
2015-04-28 00:03:11 +03:00
2015-04-27 17:41:59 +03:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-04-11 23:41:33 +03:00
2015-04-28 00:03:11 +03:00
2015-04-27 17:41:59 +03:00
2015-04-12 22:50:50 +03:00
2015-04-10 13:31:28 +03:00
2015-04-27 17:41:59 +03:00
2015-04-10 13:31:28 +03:00
2015-04-11 23:41:33 +03:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-04-27 17:41:59 +03:00
2015-07-13 06:54:35 +02:00
2015-04-11 23:41:33 +03:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-07-31 09:35:51 +02:00
2015-07-28 22:44:53 +02:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-05-04 14:08:24 +03:00
2015-07-28 22:44:53 +02:00
2014-11-06 21:48:08 +01:00
2015-04-27 17:41:59 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-04-12 22:50:50 +03:00
2015-04-11 23:41:33 +03:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-07-28 23:02:23 +02:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-08-08 03:40:23 +03:00
2015-04-27 17:41:59 +03:00
2015-05-17 03:35:35 +03:00
2015-04-11 23:41:33 +03:00
2015-08-17 13:39:34 +02:00
2015-04-12 22:50:50 +03:00
2015-04-10 13:31:28 +03:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-04-28 00:03:11 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-07-28 23:02:23 +02:00
2015-04-11 23:41:33 +03:00
2015-04-28 00:03:11 +03:00
2015-07-03 14:32:33 +02:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-07-13 10:07:19 +02:00
2015-04-27 17:41:59 +03:00
2015-05-02 04:11:36 +03:00
2015-04-10 13:31:28 +03:00
2015-08-08 03:40:23 +03:00
2015-07-28 22:44:53 +02:00
2015-04-11 23:41:33 +03:00
2015-07-28 22:44:53 +02:00
2015-07-28 10:47:21 +02:00
2015-04-10 13:31:28 +03:00
2015-07-28 22:44:53 +02:00
2015-05-02 04:11:36 +03:00
2015-04-17 01:45:11 +03:00
2015-07-28 22:44:53 +02:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-07-03 11:51:48 +02:00
2015-07-28 23:02:23 +02:00
2015-04-11 23:41:33 +03:00
2015-08-15 10:32:11 +02:00
2015-06-02 14:12:48 +02:00
2015-08-08 03:22:56 +03:00
2015-08-15 10:02:14 +02:00
2015-08-17 13:39:34 +02:00
2015-04-10 13:31:28 +03:00
2015-07-28 22:44:53 +02:00
2015-04-27 17:41:59 +03:00
2015-04-27 17:41:59 +03:00
2015-04-10 13:31:28 +03:00
2015-04-27 17:41:59 +03:00
2015-07-28 22:44:53 +02:00
2015-05-02 03:49:07 +03:00
2015-07-28 22:44:53 +02:00
2015-04-11 23:41:33 +03:00
2015-04-27 17:41:59 +03:00
2015-04-10 13:31:28 +03:00
2015-04-27 18:20:48 +03:00
2015-07-03 14:33:24 +02:00
2015-04-10 13:31:28 +03:00
2015-04-11 23:41:33 +03:00
2015-05-02 03:44:07 +03:00
2015-08-15 10:32:11 +02:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-08-08 03:40:23 +03:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-04-12 22:50:50 +03:00
2015-07-28 23:02:23 +02:00
2015-05-02 03:56:04 +03:00
2015-04-12 22:50:50 +03:00
2015-04-27 17:41:59 +03:00
2015-04-11 23:41:33 +03:00
2015-07-28 22:44:53 +02:00
2015-08-15 10:02:14 +02:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-07-16 22:14:32 +02:00
2015-08-17 13:39:34 +02:00
2015-08-08 03:40:23 +03:00
2015-04-10 13:31:28 +03:00
2015-08-17 13:39:34 +02:00
2015-05-02 03:44:07 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-04-28 02:21:03 +03:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-04-11 23:41:33 +03:00
2015-07-28 22:44:53 +02:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-04-28 00:03:11 +03:00
2015-05-31 22:53:06 +02:00
2015-04-10 13:31:28 +03:00
2015-07-21 12:42:06 +02:00
2015-07-31 09:35:51 +02:00
2015-07-28 22:44:53 +02:00
2015-04-28 02:21:03 +03:00
2015-04-11 23:41:33 +03:00
2015-05-02 03:44:07 +03:00
2015-04-10 13:31:28 +03:00
2015-07-28 22:44:53 +02:00
2015-04-10 13:31:28 +03:00
2015-04-17 01:43:19 +03:00
2015-08-15 10:02:14 +02:00
2015-04-10 13:31:28 +03:00
2015-04-10 13:31:28 +03:00
2015-04-11 23:41:33 +03:00
2015-05-02 03:49:07 +03:00
2015-04-11 23:41:33 +03:00
2015-05-02 03:44:07 +03:00
2015-07-28 23:02:23 +02:00
2015-04-28 00:03:11 +03:00
2015-04-10 13:31:28 +03:00
2015-04-11 23:41:33 +03:00
2015-04-10 13:31:28 +03:00
2015-07-28 22:44:53 +02:00
2015-07-28 10:49:42 +02:00
2014-08-13 12:06:55 +02:00
2015-07-13 08:48:18 +02:00
2015-07-28 22:44:53 +02:00
2015-04-27 17:41:59 +03:00
2015-04-10 13:31:28 +03:00
2015-07-28 22:44:53 +02:00
2015-04-10 13:31:28 +03:00
2015-07-28 22:44:53 +02:00
2015-07-28 22:44:53 +02:00
2015-07-28 22:44:53 +02:00
2015-04-11 23:41:33 +03:00
2015-04-11 23:41:33 +03:00
2015-04-11 23:41:33 +03:00