forked from github/kensanata.oddmuse
ce82a328b6
In bullet lists, the $around parameter would overshoot. The link would say around=20, for example, when in fact the correct value would be around=18. It would add the "* " of the next list item, apparently. The edit link would still look good because the test we're using is "$EditParagraphs[0]->[1] <= $pos" -- but if we then don't set "$pos = $EditParagraphs[0]->[1]" it won't help as we'll get a "Could not identify the paragraph you were editing" error as soon as we try to edit with around=20 instead of around=18.
300 lines
8.6 KiB
Perl
300 lines
8.6 KiB
Perl
# Copyright (C) 2014 Alex Schroeder <alex@gnu.org>
|
|
#
|
|
# This program is free software: you can redistribute it and/or modify it under
|
|
# the terms of the GNU General Public License as published by the Free Software
|
|
# Foundation, either version 3 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful, but WITHOUT
|
|
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
|
|
# FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along with
|
|
# this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
require 't/test.pl';
|
|
package OddMuse;
|
|
use Test::More tests => 56;
|
|
use utf8;
|
|
clear_pages();
|
|
|
|
AppendStringToFile($ConfigFile, "\$CommentsPrefix = 'Comments on ';\n");
|
|
|
|
add_module('edit-paragraphs.pl');
|
|
|
|
my $text = q{Give me a torch: I am not for this ambling;
|
|
Being but heavy, I will bear the light.
|
|
|
|
Nay, gentle Romeo, we must have you dance.
|
|
|
|
|
|
Not I, believe me: you have dancing shoes
|
|
With nimble soles: I have a soul of lead
|
|
So stakes me to the ground I cannot move.
|
|
};
|
|
|
|
my $page = update_page('Romeo_and_Mercutio', $text);
|
|
for my $paragraph (split(/\n\n+/, $text)) {
|
|
test_page($page, 'action=edit-paragraph;title=Romeo_and_Mercutio;around=\d*;paragraph='
|
|
. UrlEncode($paragraph));
|
|
}
|
|
|
|
# Check whether the form is right.
|
|
|
|
ok($page =~ /action=edit-paragraph;title=Romeo_and_Mercutio;around=(\d*);paragraph=([^"]*)/, 'found example link to use');
|
|
my $around = $1;
|
|
my $enc = $2;
|
|
my $par = UrlDecode($enc);
|
|
xpath_test(get_page("action=edit-paragraph title=Romeo_and_Mercutio around=$around paragraph=$enc"),
|
|
q'//input[@type="hidden"][@value="Romeo_and_Mercutio"][@name="title"]',
|
|
q'//input[@type="hidden"][@value="edit-paragraph"][@name="action"]',
|
|
qq'//textarea[text()="$par"]',
|
|
qq'//input[\@type="hidden"][\@value="$around"][\@name="around"]');
|
|
|
|
# Test for extra links in empty paragraphs before and after tables.
|
|
|
|
add_module('creole.pl');
|
|
|
|
$text = q{|PARIS |JULIET |
|
|
|Come you to make confession to this father? |To answer that, I should confess to you. |
|
|
|Do not deny to him that you love me. |I will confess to you that I love him. |
|
|
|So will ye, I am sure, that you love me. | |
|
|
|
|
-- William Shakespeare, Romeo and Juliet, Act IV, Scene I
|
|
};
|
|
|
|
$page = update_page('Paris_and_Juliet', $text);
|
|
test_page_negative($page, '\|', '</table><p><a ');
|
|
|
|
for my $row (split(/\n/, $text)) {
|
|
test_page($page, 'action=edit-paragraph;title=Paris_and_Juliet;around=\d*;paragraph='
|
|
. UrlEncode($row));
|
|
}
|
|
|
|
$text = q{== Romeo and Juliet, Act III, Scene II
|
|
|
|
* Tybalt is gone, and Romeo banished;
|
|
Romeo that kill'd him, he is banished.
|
|
* O God! did Romeo's hand shed Tybalt's blood?
|
|
* It did, it did; alas the day, it did!
|
|
};
|
|
|
|
$page = update_page('Nurse_and_Juliet', $text);
|
|
|
|
for my $item (split(/\n(?=[*])/, $text)) {
|
|
my $str = UrlEncode($item);
|
|
$str =~ s/\*/\\*/g;
|
|
test_page($page, 'action=edit-paragraph;title=Nurse_and_Juliet;around=\d*;paragraph='
|
|
. $str);
|
|
}
|
|
|
|
$text = q{Benvolio: Tell me in sadness, who is that you love.
|
|
|
|
Romeo: What, shall I groan and tell thee?
|
|
|
|
Benvolio: Groan! why, no. But sadly tell me who.
|
|
|
|
Romeo: Bid a sick man in sadness make his will: Ah, word ill urged to
|
|
one that is so ill! In sadness, cousin, I do love a woman.
|
|
|
|
Benvolio: I aim'd so near, when I supposed you loved.
|
|
|
|
Romeo: A right good mark-man! And she's fair I love.
|
|
|
|
Benvolio: A right fair mark, fair coz, is soonest hit.
|
|
};
|
|
|
|
# Replace the first occurence.
|
|
|
|
test_page(update_page('Benvolio_and_Romeo', $text),
|
|
'Benvolio: Tell me in sadness');
|
|
test_page(get_page('action=edit-paragraph title=Benvolio_and_Romeo '
|
|
. 'around=0 paragraph=Benvolio text=Ben'),
|
|
# not using update_page because of the parameters
|
|
'Status: 302');
|
|
test_page(get_page('Benvolio_and_Romeo'),
|
|
'Ben: Tell me in sadness',
|
|
'Benvolio: Groan!');
|
|
|
|
# Reset and try again but replace the occurence around 105.
|
|
|
|
update_page('Benvolio_and_Romeo', $text);
|
|
test_page(get_page('action=edit-paragraph title=Benvolio_and_Romeo '
|
|
. 'around=105 '
|
|
. 'paragraph=Benvolio text=Ben'),
|
|
# not using update_page because of the parameters
|
|
'Status: 302');
|
|
test_page(get_page('Benvolio_and_Romeo'),
|
|
'Benvolio: Tell me in sadness',
|
|
'Ben: Groan!');
|
|
|
|
SKIP: {
|
|
|
|
skip "We don't do fuzzy matching anymore.", 3;
|
|
|
|
# Try again but now let's simulate a page changed in the background
|
|
# such that the text is now not exactly at the expected position, but
|
|
# close by.
|
|
$text =~ s/tell thee/tell you/;
|
|
update_page('Benvolio_and_Romeo', $text);
|
|
test_page(get_page('action=edit-paragraph title=Benvolio_and_Romeo '
|
|
. 'around=105 '
|
|
. 'paragraph=Benvolio text=Ben'),
|
|
# not using update_page because of the parameters
|
|
'Status: 302');
|
|
test_page(get_page('Benvolio_and_Romeo'),
|
|
'Benvolio: Tell me in sadness',
|
|
'Ben: Groan!');
|
|
}
|
|
|
|
# HTML encoding.
|
|
|
|
$text = q{I am hurt.
|
|
<em>A plague o' both your houses!</em> I am sped.
|
|
};
|
|
xpath_test(get_page('action=edit-paragraph title=Mercutio paragraph="' . UrlEncode($text) . '"'),
|
|
qq'//textarea[text()="$text"]');
|
|
|
|
# Make sure the link at the very end is shown.
|
|
|
|
$text = q{
|
|
{{{
|
|
BENVOLIO Romeo, away, be gone!
|
|
The citizens are up, and Tybalt slain.
|
|
Stand not amazed: the prince will doom thee death,
|
|
If thou art taken: hence, be gone, away!
|
|
|
|
ROMEO O, I am fortune's fool!
|
|
}}}
|
|
|
|
----
|
|
|
|
William Shakespeare, Romeo and Juliet, Act III, Scene I
|
|
};
|
|
|
|
$page = update_page('Benvolio_and_Romeo', $text);
|
|
test_page_negative($page, '</pre><p><a ', '<p><a ');
|
|
test_page($page, 'fool!<a ', '</pre><hr ?/><p>William', 'Scene I<a');
|
|
|
|
# Mixed lists.
|
|
|
|
$text = q{* One
|
|
## Two
|
|
};
|
|
|
|
$page = update_page('Alex_Daniel', $text);
|
|
for my $item (split(/\n(?=[\*\#])/, $text)) {
|
|
my $str = UrlEncode($item);
|
|
$str =~ s/\*/\\*/g;
|
|
test_page($page, 'action=edit-paragraph;title=Alex_Daniel;around=\d*;paragraph='
|
|
. $str);
|
|
}
|
|
|
|
# Comments, the last element in particular.
|
|
|
|
$text = q{Test
|
|
|
|
-- Anonymous
|
|
|
|
----
|
|
|
|
Test
|
|
|
|
-- Real Anonymous
|
|
};
|
|
|
|
$page = update_page('Comments_on_Alex_Daniel', $text);
|
|
test_page($page, 'action=edit-paragraph;title=Comments_on_Alex_Daniel;around=\d*;paragraph=--%20Real%20Anonymous%0a');
|
|
|
|
# More than one newline at the end.
|
|
|
|
$text = q{one
|
|
|
|
two
|
|
|
|
};
|
|
|
|
$page = update_page('Alex_Daniel', $text);
|
|
for my $item (split(/\n+/, $text)) {
|
|
my $str = UrlEncode($item);
|
|
$str =~ s/\*/\\*/g;
|
|
test_page($page, 'action=edit-paragraph;title=Alex_Daniel;around=\d*;paragraph='
|
|
. $str);
|
|
}
|
|
|
|
# More HTML encoding.
|
|
|
|
$text = q{Test.
|
|
|
|
<test1>
|
|
|
|
<test2>
|
|
|
|
<test3>
|
|
};
|
|
|
|
$page = update_page('Test', $text);
|
|
test_page_negative(get_page('action=browse id=Test raw=1'), '<');
|
|
# HTML encoded text is longer: every < > counts adds 3. Thus 33 + 6x3 = 51.
|
|
my $action = 'action=edit-paragraph;title=Test;around=51;paragraph=' . UrlEncode("<test3>\n");
|
|
test_page($page, $action);
|
|
test_page(get_page(join(' ', split(';', $action))), QuoteHtml("<test3>\n"));
|
|
# test error
|
|
test_page(get_page('action=edit-paragraph title=Test'
|
|
. ' paragraph=' . UrlEncode("<test3>\n") # old
|
|
. ' text=' . UrlEncode("<test30>\n") # new
|
|
. ' around=1'),
|
|
'Could not identify the paragraph you were editing',
|
|
'<pre>' . QuoteHtml("<test3>\n") . '</pre>');
|
|
test_page(get_page('action=edit-paragraph title=Test'
|
|
. ' paragraph=' . UrlEncode("<test3>\n") # old
|
|
. ' text=' . UrlEncode("<test30>\n") # new
|
|
. ' around=51'), 'Status: 302');
|
|
$text =~ s/test3/test30/;
|
|
test_page(get_page('action=browse id=Test raw=1'), $text);
|
|
|
|
# ampersand in a pagename
|
|
|
|
$text = q{d4
|
|
|
|
d5
|
|
|
|
d8
|
|
|
|
d10
|
|
};
|
|
|
|
$page = update_page('D%26D', $text);
|
|
my $action = 'action=edit-paragraph;title=D%26D;around=8;paragraph=d5%0a%0a';
|
|
test_page($page, $action);
|
|
test_page(get_page(join(' ', split(';', $action))), 'd5');
|
|
# test error
|
|
test_page(get_page('action=edit-paragraph title=D%26D'
|
|
. ' paragraph=d5%0a%0a' # old
|
|
. ' text=d6%0a%0a' # new
|
|
. ' around=8'),
|
|
'Status: 302');
|
|
$text =~ s/d5/d6/;
|
|
test_page(get_page('action=browse id=D%26D raw=1'), $text);
|
|
|
|
# questionmark, square brackets, bullet lists in the edited text
|
|
|
|
$text = q{* who?
|
|
* [where]?
|
|
* why?
|
|
* what?
|
|
};
|
|
|
|
$page = update_page('Questions', $text);
|
|
my $action = 'action=edit-paragraph;title=Questions;around=18;paragraph=*%20%5bwhere%5d%3f%0a';
|
|
test_page($page, quotemeta($action));
|
|
test_page(get_page(join(' ', split(';', $action))), '\[where\]\?');
|
|
# test error
|
|
test_page(get_page('action=edit-paragraph title=Questions'
|
|
. ' paragraph=*%20%5bwhere%5d%3f%0a' # old
|
|
. ' text=*%20how%3f%0a' # new
|
|
. ' around=18'),
|
|
'Status: 302');
|
|
$text =~ s/\[where\]\?/how?/;
|
|
test_page(get_page('action=browse id=Questions raw=1'), quotemeta($text));
|