archive/oddmuse
2
0
Fork 0
forked from github/kensanata.oddmuse
Code Pull Requests Activity
Files
46cb69a6c3b82ff71cae1778606baff8bfc13f1e
oddmuse/modules
History
Alex Schroeder 46cb69a6c3 Use helper functions for accessing the file system 
As we derive a lot of filenames from strings in UTF-8 encoded files, we
need to make sure that any filename that might might be set by a user –
including all the filenames containing a directory deriving from
$DataDir – are passed through utf8::encode. That is, every character
gets replaced with a sequence of one or more characters that represent
the individual bytes of the character and the UTF8 flag is turned off.

In other words, -d $DataDir might not work if $DataDir contains a UTF-8
encoded string. The solution is to use the following replacements:

-f $name            IsFile($name)
-e $name            IsFile($name)
-d $name            IsDir($name)
(stat($name))[9]    Modified($name)
-M $name            $Now - Modified($name)
-z $name            ZeroSize($name)
unlink $name        Unlink($name)
mkdir $name         CreateDir($name)
rmdir $name         RemoveDir($name)

(Using IsFile for -e is probably not ideal?)

If you don’t, and Oddmuse gets used with Mojolicious, and you use the
Namespaces Extension, and a namespace contains non-ASCII characters such
as ä, ö, or ü, these characters will end up as part of $DataDir and
trigger the problem.

I also wonder whether we should be using some other Perl library.
2016-06-17 14:49:34 +02:00
..
near-links
…
translations
Add Spanish national days
2016-05-28 13:58:57 +02:00
404handler.pl
404handler.pl: use our for variables
2015-07-28 10:55:13 +02:00
accesskeys.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
admin.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
adsense.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
advanced-uploads.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
age.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
aggregate.pl
Return objects where it begs for it
2015-09-04 04:55:48 +03:00
agree-disagree.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
all.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
anchors.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
antispam.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
archive.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
askpage.pl
askpage.pl: forgot to add some variables to our (...)
2015-09-07 03:47:23 +03:00
atom.pl
atom.pl: use PUTDATA
2015-09-12 19:06:59 +02:00
autolock.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
backlinkage.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
backlinks.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
ban-contributors.pl
Trans.: "Consider banning the IP number as well: "
2015-10-15 19:18:55 +02:00
ban-quick-editors.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
banned-regexps.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
bbcode.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
big-brother.pl
big-brother.pl: Make sure restricted URL is used
2015-09-21 17:56:02 +02:00
blockquote.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
calendar.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
canonical.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
cart.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
checkbox.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
clustermap.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
comment-div-wrapper.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
commentcount.pl
Translation: "Comments on " and "Comment on"
2015-10-15 19:29:35 +02:00
compilation.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
context.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
creationdate.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
creole.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
creoleaddition.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
crossbar.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
crumbs.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
css-install.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
csv.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
dates.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
delete-all.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
despam.pl
Return objects where it begs for it
2015-09-04 04:55:48 +03:00
diff.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
div-foo.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
dojo.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
doubleclick.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
download.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
drafts.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
duckduckgo-search.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
dynamic-comments.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
dynlogo.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
edit-assist.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
edit-cluster.pl
Fix tests ($ShowAll)
2015-10-21 12:15:25 +03:00
edit-paragraphs.js
…
edit-paragraphs.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
emailquote.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
emoji.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
enclosure.pl
Return objects where it begs for it
2015-09-04 04:55:48 +03:00
faq.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
fckeditor.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
fieldlist.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
find.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
fix-encoding.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
flickrgallery.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
footnotes.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
form_timeout.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
forms.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
fractions.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
gd_security_image.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
git-another.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
git.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
google-custom-search.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
google-plus-one.pl
google-plus-one.pl: fix plusone action
2015-09-04 14:00:44 +02:00
google-search.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
gotobar.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
gravatar.pl
Translation: "Email: "
2015-10-15 14:41:55 +02:00
grep.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
header-and-footer-templates.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
headers.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
headlines.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
hibernal.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
hiddenpages.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
honeypot.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
html-template.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
html-uploads.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
htmlcomment.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
htmllinks.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
image.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
imagify.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
index.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
irc.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
joiner.pl
“link blow” → “link below”
2015-10-18 02:48:06 +03:00
journal-rss.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
lang.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
latex.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
like.pl
Remove trailing whitespace
2015-07-28 10:47:21 +02:00
linebreaks.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
link-all.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
links.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
linktagmap.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
list-banned-content.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
listlocked.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
listmimetypes.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
listtags.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
live-templates.pl
Return objects where it begs for it
2015-09-04 04:55:48 +03:00
load-lang.pl
load-lang.pl: Fix code and add test
2016-05-28 09:30:59 +02:00
localnames.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
localtime.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
logbannedcontent.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
login.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
logout.pl
Translation: fix Return to
2015-10-14 12:39:55 +02:00
mac.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
mail.pl
Translation: "Email: "
2015-10-15 14:41:55 +02:00
markdown-rule.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
markup.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
module-bisect.pl
Biscecting -> Bisection (typo)
2015-10-19 23:17:39 +03:00
module-updater.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
moin.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
monitor.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
multi-url-spam-block.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
namespaces.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
near-links.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
nearlink-create.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
new-window.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
no-question-mark.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
nosearch.pl
nosearch.pl: code style
2015-10-31 02:58:00 +02:00
not-found-handler.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
numbered-list.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
offline.pl
Full support for arrayref in $StyleSheet
2015-10-26 01:03:42 +02:00
olocalmap.pl
Return objects where it begs for it
2015-09-04 04:55:48 +03:00
open-proxy.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
org-mode.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
orphans.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
page-trail.pl
Translation: "Trail: "
2015-10-15 14:36:51 +02:00
page-type.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
paragraph-link.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
partial-journal.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
permanent-anchors.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
pingback-server.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
plainsite.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
poetry.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
portrait-support.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
preview.pl
preview.pl: remove trailing whitespace
2015-09-21 09:41:00 +02:00
private-pages.pl
Return objects where it begs for it
2015-09-04 04:55:48 +03:00
private-wiki.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
publish.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
put.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
pygmentize.pl
pygmentize.pl: warn if an error occured
2015-07-16 22:14:32 +02:00
questionasker.pl
Introducing @MyFormChanges
2015-08-18 11:11:13 +02:00
recaptcha.pl
Introducing @MyFormChanges
2015-08-18 11:11:13 +02:00
referrer-rss.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
referrer-tracking.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
relation.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
sabifoo.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
search-list.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
search-shortcut.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
searchtags.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
setext.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
show-comments.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
sidebar.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
signature.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
simple-rules.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
sistersites.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
sitemap-index.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
sitemap.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
small.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
smarttitles.pl
With /x, # has a special meaning (escape it!)
2015-09-11 02:55:18 +03:00
smiles.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
smiley-dir.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
static-copy.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
static-hybrid.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
subscriberc.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
svg-edit.pl
Translation: "Summary of your changes: "
2015-10-15 19:13:13 +02:00
sync.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
tables-in-lists.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
tables-long.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
tables.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
tagmap.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
tags.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
templates.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
tex.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
throttle.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
thumbs.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
timezone.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
toc-headers.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
toc-js.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
toc.pl
Workaround for utf8::decode bug (sometimes utf8 chars were not decoded)
2015-09-16 04:13:02 +03:00
today.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
translation-links.pl
Translation: "Translated page: "
2015-10-15 14:34:28 +02:00
translations.pl
Translation: "This page is a translation of %s. "
2015-10-15 14:27:17 +02:00
upgrade.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
upload.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
uploader.js
…
usemod.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
vcard.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
wanted.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
webapp.pl
Full support for arrayref in $StyleSheet
2015-10-26 01:03:42 +02:00
webdav.pl
Use helper functions for accessing the file system
2016-06-17 14:49:34 +02:00
weblog-1.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
weblog-2.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
weblog-3.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
weblog-4.pl
Translation: "Title: "
2015-10-15 14:24:08 +02:00
weblog-tracking.pl
use v5.10 everywhere + enabled test in meta.t
2015-08-18 10:48:03 +02:00
wordstem.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00
xfn.pl
No more /o, modifiers sorted alphabetically
2015-08-23 21:22:12 +03:00