Commit Graph

21 Commits

Author SHA1 Message Date
Alex Schroeder
0c0efdd2c8 banned-regexps.pl: exclude urls 2016-08-08 11:31:06 +02:00
Alex Schroeder
58e9a1e240 use v5.10 everywhere + enabled test in meta.t 2015-08-18 10:48:03 +02:00
Alex Schroeder
642cec5e7d Fix utf8 encoding and enable meta test
We now check POD and code with two separate checks. One checks for use
utf8, the other checks for =encoding utf8.
2015-07-28 23:02:23 +02:00
Aleks-Daniel Jakimenko
df87ff82c3 No more redundant 'package OddMuse;' 2015-04-27 17:41:59 +03:00
Aleks-Daniel Jakimenko
6f8d281d79 No more "use vars"! 2015-04-10 13:31:28 +03:00
Aleks-Daniel Jakimenko
88aac79df3 It is not that weird anymore! *Sub = *NewSub changed to *Sub = \&NewSub
We have just read-TFM and figured out that we can use \&Sub. This way it
passes "use strict" but produces a warning with "use warnings" (the
warning is "Subroutine package::Sub redefined at ...").

We can "fix" it with "no warnings 'redefine'"
2015-03-30 09:58:33 +03:00
Alex Schroeder
4df99dc798 Banning modules use our instead of my
All the banning modules have a problem. They use code like the
following:

*StrangeOldBannedContent = *BannedContent;
*BannedContent = *StrangeNewBannedContent;

The code above changes both the sub and the variable. $BannedContent now
points to $StrangeNewBannedContent (which is undefined) and the name of
the Banned Content page is only accessible via $StrangeOldBannedContent.
If we copy $StrangeOldBannedContent to $BannedContent, everything else
will keep working.

$BannedContent = $StrangeOldBannedContent;

But now use strict will not work. When we tried this:

my $StrangeOldBannedContent; # use strict

Then BannedContent disappeared from the admin page as shown by the tests
in strange-spam.t; the correct solution uses our instead of my.

I'm not sure why.
2015-03-30 00:29:39 +02:00
Alex Schroeder
c48a45d0b4 logbannedcontent.pl uses strict
Uses the same code and comment as banned-regexps.pl
2015-03-29 15:17:13 +02:00
Alex Schroeder
ada41ef14f Use strict
Added a comment to explain these lines.

my $RegexpOldBannedContent;
*RegexpOldBannedContent = *BannedContent;
*BannedContent = *RegexpNewBannedContent;
$BannedContent = $RegexpOldBannedContent;
2015-03-28 15:22:45 +01:00
Aleks-Daniel Jakimenko
4492ede096 "use strict;" in modules (some modules have problems) 2015-03-27 03:01:01 +02:00
Alex Schroeder
5aba2ae56f Fixed typo in AddModuleDescription sub name 2014-08-21 22:23:23 +02:00
Alex Jakimenko
ee932dee37 Automatically reformatted modules 2014-08-21 07:29:46 +03:00
Alex Schroeder
8e2da8a1a9 Save $1 to prevent it from being overwritten by Tss. 2013-01-31 09:50:11 +01:00
Alex Schroeder
872b914c90 Merge branch 'master' of git.sv.gnu.org:/srv/git/oddmuse 2013-01-31 09:43:43 +01:00
Alex Schroeder
1e6f732fa9 Use LogWrite. 2013-01-31 09:43:05 +01:00
Alex Schroeder
925f0788fb Add $1 to the explanation if such a group is part of the regular
expression.
2013-01-31 09:29:25 +01:00
Alex Schroeder
7d166842f0 Make sure banning happens without logging in RegexpNewBannedContent. 2013-01-25 00:03:51 +01:00
Alex Schroeder
c6943cad7b Package Oddmuse. 2013-01-24 23:51:12 +01:00
Alex Schroeder
c29037a9d6 Delete code that doesn't belong. 2013-01-24 23:50:31 +01:00
Alex Schroeder
e1b429c3b7 New 2013-01-24 23:45:24 +01:00
Alex Schroeder
9d11d42e5e New 2013-01-24 23:30:32 +01:00